Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select: removes portal property from tooltip and replace with position #335

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

The Tooltip portal property renders the tooltip below surface UI when surface UI is the parent. Reverting this change and use position prop instead.

JIRA TASK (Eightfold Employees Only):

ENG-28213

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST PLAN:

pull the PR branch then do yarn and yarn storybook to verify the tooltip position and it still shows for the typical use case.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f013e5:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ffa0373). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage        ?   88.13%           
=======================================
  Files           ?      403           
  Lines           ?    10872           
  Branches        ?     3684           
=======================================
  Hits            ?     9582           
  Misses          ?     1266           
  Partials        ?       24           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit 07cd4e4 into EightfoldAI:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants