Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added fix for split btn icon #314

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

mfazil-eightfold
Copy link
Contributor

SUMMARY:

Fixing the slipt button icon path.

Screen.Recording.2022-08-19.at.5.13.01.PM.mov

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-27267

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c62e6c4:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@98f1f70). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage        ?   88.50%           
=======================================
  Files           ?      400           
  Lines           ?    10756           
  Branches        ?     3636           
=======================================
  Hits            ?     9520           
  Misses          ?     1213           
  Partials        ?       23           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mfazil-eightfold mfazil-eightfold merged commit a1c0651 into EightfoldAI:main Aug 19, 2022
@mfazil-eightfold mfazil-eightfold deleted the split-btn-icon-1 branch August 19, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants