Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toggle: fix toggles getting squished in certain scenarios #307

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Same as RadioButton and Checkbox, with longer labels or nodes, the selector gets squished.

JIRA TASK (Eightfold Employees Only):

ENG-26810

CHANGE TYPE:

  • [ X] Bugfix Pull Request
  • Feature Pull Request

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da9347a:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@0f17fac). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage        ?   88.96%           
=======================================
  Files           ?      396           
  Lines           ?    10705           
  Branches        ?     3619           
=======================================
  Hits            ?     9524           
  Misses          ?     1159           
  Partials        ?       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dkilgore-eightfold dkilgore-eightfold merged commit 23ee9dd into EightfoldAI:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants