fix: select: fixes select clear when items are toggled #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkilgore-eightfold
requested review from
slee-eightfold,
ychhabra-eightfold and
jhoward-eightfold
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a284304:
|
jhoward-eightfold
approved these changes
Aug 11, 2022
dkilgore-eightfold
added a commit
to dkilgore-eightfold/octupledownstream
that referenced
this pull request
Aug 11, 2022
* fix: select: fixes select clear when items are toggled * chore: adds select uts (cherry picked from commit 72ba459)
dkilgore-eightfold
added a commit
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Octuple Select w/ clear component (link)
Steps to reproduce the bug:
Select School from the dropdown
You see the clear button (x) to the left of “School”
Select School again.
You don’t see the clear button
Select School again and you’ll see the clear button.
selectClearable.mp4
JIRA TASK (Eightfold Employees Only):
ENG-26684
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the pr changes and run
yarn, thenyarn storybook, verify changes to the Select With Clear story, or implement a clearable select via CodeSandbox CI