Skip to content

Commit

Permalink
chore: address pr feedback and dedupe button class name
Browse files Browse the repository at this point in the history
  • Loading branch information
@dkilgore-eightfold
dkilgore-eightfold committed Aug 2, 2022
1 parent db9cc2e commit 6a24336
Show file tree
Hide file tree
Showing 28 changed files with 443 additions and 443 deletions.
1 change: 0 additions & 1 deletion src/components/Button/BaseButton.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export const BaseButton: FC<InternalButtonProps> = React.forwardRef(

const buttonBaseSharedClassNames: string = mergeClasses([
classNames,
styles.button,
{
[styles.buttonSmall]:
size === ButtonSize.Flex && largeScreenActive,
Expand Down
1 change: 1 addition & 0 deletions src/components/Button/SplitButton/SplitButton.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const SplitButton: FC<SplitButtonProps> = React.forwardRef(

const splitButtonClassNames: string = mergeClasses([
classNames,
styles.button,
styles.splitButton,
{
[styles.buttonSmall]:
Expand Down
36 changes: 18 additions & 18 deletions src/components/DateTimePicker/Internal/Tests/__snapshots__/partial.rtl.shot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-prev-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-prev-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -106,7 +106,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-year-btn button button-neutral button button-small pill-shape",
"class": "picker-year-btn button button-neutral button-small pill-shape",
},
"children": Array [
Node {
Expand Down Expand Up @@ -157,7 +157,7 @@ LoadedCheerio {
"next": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-next-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-next-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -277,7 +277,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-year-btn button button-neutral button button-small pill-shape",
"class": "picker-year-btn button button-neutral button-small pill-shape",
},
"children": Array [
Node {
Expand Down Expand Up @@ -328,7 +328,7 @@ LoadedCheerio {
"next": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-next-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-next-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -422,7 +422,7 @@ LoadedCheerio {
"prev": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-prev-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-prev-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -523,7 +523,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-next-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-next-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -610,7 +610,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-year-btn button button-neutral button button-small pill-shape",
"class": "picker-year-btn button button-neutral button-small pill-shape",
},
"children": Array [
Node {
Expand Down Expand Up @@ -663,7 +663,7 @@ LoadedCheerio {
"prev": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-prev-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-prev-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -14909,7 +14909,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-prev-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-prev-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -14994,7 +14994,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-year-btn button button-neutral button button-small pill-shape",
"class": "picker-year-btn button button-neutral button-small pill-shape",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15045,7 +15045,7 @@ LoadedCheerio {
"next": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-next-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-next-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15165,7 +15165,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-year-btn button button-neutral button button-small pill-shape",
"class": "picker-year-btn button button-neutral button-small pill-shape",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15216,7 +15216,7 @@ LoadedCheerio {
"next": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-next-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-next-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15310,7 +15310,7 @@ LoadedCheerio {
"prev": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-prev-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-prev-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15411,7 +15411,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-next-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-next-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15498,7 +15498,7 @@ LoadedCheerio {
Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-year-btn button button-neutral button button-small pill-shape",
"class": "picker-year-btn button button-neutral button-small pill-shape",
},
"children": Array [
Node {
Expand Down Expand Up @@ -15551,7 +15551,7 @@ LoadedCheerio {
"prev": Node {
"attribs": Object {
"aria-disabled": "false",
"class": "picker-header-super-prev-btn button button-neutral button button-small pill-shape icon-left",
"class": "picker-header-super-prev-btn button button-neutral button-small pill-shape icon-left",
},
"children": Array [
Node {
Expand Down
8 changes: 4 additions & 4 deletions src/components/Table/Tests/__snapshots__/Table.expand.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1898,7 +1898,7 @@ LoadedCheerio {
"aria-checked": "true",
"aria-disabled": "false",
"aria-pressed": "true",
"class": "pagination-button active button button-neutral button button-medium",
"class": "pagination-button active button button-neutral button-medium",
},
"children": Array [
Node {
Expand Down Expand Up @@ -1990,7 +1990,7 @@ LoadedCheerio {
"aria-checked": "true",
"aria-disabled": "false",
"aria-pressed": "true",
"class": "pagination-button active button button-neutral button button-medium",
"class": "pagination-button active button button-neutral button-medium",
},
"children": Array [
Node {
Expand Down Expand Up @@ -2121,7 +2121,7 @@ LoadedCheerio {
"aria-checked": "true",
"aria-disabled": "false",
"aria-pressed": "true",
"class": "pagination-button active button button-neutral button button-medium",
"class": "pagination-button active button button-neutral button-medium",
},
"children": Array [
Node {
Expand Down Expand Up @@ -2213,7 +2213,7 @@ LoadedCheerio {
"aria-checked": "true",
"aria-disabled": "false",
"aria-pressed": "true",
"class": "pagination-button active button button-neutral button button-medium",
"class": "pagination-button active button button-neutral button-medium",
},
"children": Array [
Node {
Expand Down
Loading

0 comments on commit 6a24336

Please sign in to comment.