Skip to content

Commit

Permalink
chore: tidy: renames types and fix console warnings in svg components (…
Browse files Browse the repository at this point in the history 
…#211)
  • Loading branch information
@dkilgore-eightfold
dkilgore-eightfold authored Jun 29, 2022
1 parent 9a385ca commit 0a86e97
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 31 deletions.
4 changes: 2 additions & 2 deletions src/__snapshots__/storybook.test.js.snap
View file
Git LFS file not shown
8 changes: 4 additions & 4 deletions src/components/Empty/SVG/DefaultEmptyMessagesImg.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,25 @@ export const DefaultEmptyMessagesImg = (): JSX.Element => {
d="M131.098 145.069C125.349 140.58 119.665 136.448 116.52 133.384C116.016 132.893 115.288 132.671 114.598 132.81C35.5718 148.779 -9.97428 65.6821 65.669 27.1035C65.7558 27.0592 65.8525 27.0185 65.9449 26.9875C142.983 1.22162 204.241 81.5443 135.362 124.844C134.772 125.214 134.381 125.876 134.381 126.572L134.381 143.483C134.381 145.166 132.424 146.105 131.098 145.069Z"
fill="white"
stroke="#8ED0FA"
stroke-width="6"
strokeWidth="6"
/>
<path
d="M66.3926 86.6624C70.9586 86.6624 74.3926 82.703 74.3926 78.1624C74.3926 73.6217 70.9586 69.6624 66.3926 69.6624C61.8266 69.6624 58.3926 73.6217 58.3926 78.1624C58.3926 82.703 61.8266 86.6624 66.3926 86.6624Z"
fill="#B0F3FE"
stroke="#B0F3FE"
stroke-width="4"
strokeWidth="4"
/>
<path
d="M94.3926 86.6624C98.9586 86.6624 102.393 82.703 102.393 78.1624C102.393 73.6217 98.9586 69.6624 94.3926 69.6624C89.8266 69.6624 86.3926 73.6217 86.3926 78.1624C86.3926 82.703 89.8266 86.6624 94.3926 86.6624Z"
fill="#B0F3FE"
stroke="#B0F3FE"
stroke-width="4"
strokeWidth="4"
/>
<path
d="M122.393 86.6624C126.959 86.6624 130.393 82.703 130.393 78.1624C130.393 73.6217 126.959 69.6624 122.393 69.6624C117.827 69.6624 114.393 73.6217 114.393 78.1624C114.393 82.703 117.827 86.6624 122.393 86.6624Z"
fill="#B0F3FE"
stroke="#B0F3FE"
stroke-width="4"
strokeWidth="4"
/>
</svg>
);
Expand Down
6 changes: 3 additions & 3 deletions src/components/Empty/SVG/DefaultEmptySearchImg.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const DefaultEmptySearchImg = (): JSX.Element => {
<path
d="M183 91C188.192 91 192 86.5161 192 81.5C192 76.4839 188.192 72 183 72C177.808 72 174 76.4839 174 81.5C174 86.5161 177.808 91 183 91Z"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
/>
<circle cx="139" cy="47" r="5" fill="#B0F3FE" />
<rect x="148" y="42" width="20" height="10" rx="5" fill="#B0F3FE" />
Expand All @@ -33,14 +33,14 @@ export const DefaultEmptySearchImg = (): JSX.Element => {
<path
d="M125.26 118.259L118.189 111.187M111.824 36.9412C130.569 55.6864 130.569 86.0783 111.824 104.823C93.0788 123.569 62.6869 123.569 43.9417 104.823C25.1965 86.0783 25.1965 55.6864 43.9417 36.9412C62.6869 18.196 93.0788 18.196 111.824 36.9412ZM155.664 148.664C152.54 151.788 147.475 151.788 144.351 148.664L127.38 131.693C124.256 128.569 124.256 123.504 127.38 120.38C130.504 117.256 135.57 117.256 138.694 120.38L155.664 137.35C158.789 140.475 158.789 145.54 155.664 148.664Z"
stroke="#8ED0FA"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<path
d="M56.3926 96.6624C60.9586 96.6624 64.3926 92.703 64.3926 88.1624C64.3926 83.6217 60.9586 79.6624 56.3926 79.6624C51.8266 79.6624 48.3926 83.6217 48.3926 88.1624C48.3926 92.703 51.8266 96.6624 56.3926 96.6624Z"
fill="#B0F3FE"
stroke="#B0F3FE"
stroke-width="4"
strokeWidth="4"
/>
</svg>
);
Expand Down
16 changes: 8 additions & 8 deletions src/components/Empty/SVG/DefaultServerErrorImg.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const DefaultServerErrorImg = (): JSX.Element => {
d="M49.2784 101.405C39.3247 57.4604 105.676 18.8428 136.863 78.7671C196.578 76.1036 191.934 156.002 145.489 158L107.668 158L46.6243 158C12.7837 158 0.841885 104.068 49.2784 101.405Z"
fill="white"
stroke="#8ED0FA"
stroke-width="6"
strokeWidth="6"
/>
<path
d="M76.0193 103.097L82.4167 109.495L86.6594 105.252L80.2619 98.8548L76.0193 103.097ZM82.4167 108.081L76.38 114.117L80.6226 118.36L86.6594 112.323L82.4167 108.081ZM82.4167 109.495C82.0262 109.104 82.0262 108.471 82.4167 108.081L86.6594 112.323C88.612 110.371 88.612 107.205 86.6594 105.252L82.4167 109.495Z"
Expand All @@ -32,17 +32,17 @@ export const DefaultServerErrorImg = (): JSX.Element => {
d="M102 142C107.192 142 111 137.516 111 132.5C111 127.484 107.192 123 102 123C96.8079 123 93 127.484 93 132.5C93 137.516 96.8079 142 102 142Z"
fill="#B0F3FE"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
/>
<path
d="M161 68C166.192 68 170 63.5161 170 58.5C170 53.4839 166.192 49 161 49C155.808 49 152 53.4839 152 58.5C152 63.5161 155.808 68 161 68Z"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
/>
<path
d="M55 22C60.1921 22 64 17.5161 64 12.5C64 7.48391 60.1921 3 55 3C49.8079 3 46 7.48391 46 12.5C46 17.5161 49.8079 22 55 22Z"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
/>
<ellipse cx="108" cy="29.5" rx="6" ry="6.5" fill="#B0F3FE" />
<ellipse cx="28" cy="89.5" rx="6" ry="6.5" fill="#B0F3FE" />
Expand All @@ -52,7 +52,7 @@ export const DefaultServerErrorImg = (): JSX.Element => {
x2="148.606"
y2="24.3346"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<line
Expand All @@ -61,7 +61,7 @@ export const DefaultServerErrorImg = (): JSX.Element => {
x2="148.608"
y2="11.6065"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<line
Expand All @@ -70,7 +70,7 @@ export const DefaultServerErrorImg = (): JSX.Element => {
x2="18.6061"
y2="51.3346"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<line
Expand All @@ -79,7 +79,7 @@ export const DefaultServerErrorImg = (): JSX.Element => {
x2="18.6076"
y2="38.6065"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
</svg>
Expand Down
16 changes: 8 additions & 8 deletions src/components/Empty/SVG/DefaultTasksCompleteImg.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,22 @@ export const DefaultTasksCompleteImg = (): JSX.Element => {
<path
d="M180 98C185.192 98 189 93.5161 189 88.5C189 83.4839 185.192 79 180 79C174.808 79 171 83.4839 171 88.5C171 93.5161 174.808 98 180 98Z"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
/>
<circle cx="139" cy="47" r="5" fill="#B0F3FE" />
<path
d="M56.3926 96.6624C60.9586 96.6624 64.3926 92.703 64.3926 88.1624C64.3926 83.6217 60.9586 79.6624 56.3926 79.6624C51.8266 79.6624 48.3926 83.6217 48.3926 88.1624C48.3926 92.703 51.8266 96.6624 56.3926 96.6624Z"
fill="#B0F3FE"
stroke="#B0F3FE"
stroke-width="4"
strokeWidth="4"
/>
<circle
cx="98"
cy="79"
r="60"
fill="white"
stroke="#8ED0FA"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<path
Expand All @@ -42,7 +42,7 @@ export const DefaultTasksCompleteImg = (): JSX.Element => {
<path
d="M16 26C21.1921 26 25 21.5161 25 16.5C25 11.4839 21.1921 7 16 7C10.8079 7 7 11.4839 7 16.5C7 21.5161 10.8079 26 16 26Z"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
/>
<ellipse cx="38" cy="35.5" rx="6" ry="6.5" fill="#B0F3FE" />
<ellipse cx="171" cy="35.5" rx="6" ry="6.5" fill="#B0F3FE" />
Expand All @@ -52,7 +52,7 @@ export const DefaultTasksCompleteImg = (): JSX.Element => {
x2="142"
y2="13"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<line
Expand All @@ -61,7 +61,7 @@ export const DefaultTasksCompleteImg = (): JSX.Element => {
x2="151"
y2="4"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<line
Expand All @@ -70,7 +70,7 @@ export const DefaultTasksCompleteImg = (): JSX.Element => {
x2="13"
y2="87"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
<line
Expand All @@ -79,7 +79,7 @@ export const DefaultTasksCompleteImg = (): JSX.Element => {
x2="22"
y2="78"
stroke="#B0F3FE"
stroke-width="6"
strokeWidth="6"
strokeLinecap="round"
/>
</svg>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Table/Internal/OcTable.types.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export interface ExpandableConfig<RecordType> {
}

// =================== Render ===================
export type PanelRender<RecordType> = (
export type FrameWrapperRender<RecordType> = (
data: readonly RecordType[]
) => React.ReactNode;

Expand Down Expand Up @@ -230,8 +230,8 @@ export interface OcTableProps<RecordType = unknown> {
rowClassName?: string | RowClassName<RecordType>;

// Additional Part
title?: PanelRender<RecordType>;
footer?: PanelRender<RecordType>;
title?: FrameWrapperRender<RecordType>;
footer?: FrameWrapperRender<RecordType>;
summary?: (data: readonly RecordType[]) => React.ReactNode;

// Customize
Expand Down
2 changes: 1 addition & 1 deletion src/components/Tabs/Tabs.test.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Enzyme.configure({ adapter: new Adapter() });

let matchMedia: any;

describe('Panel', () => {
describe('Tabs', () => {
let wrapper: ReactWrapper;

const tabs = [1, 2, 3, 4].map((i) => ({
Expand Down
4 changes: 2 additions & 2 deletions src/components/Tabs/__snapshots__/Tabs.test.tsx.snap
View file
Git LFS file not shown

0 comments on commit 0a86e97

Please sign in to comment.