implement generator for Stream effect #322
Merged
+152
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikearnaldi
reviewed
Oct 18, 2020
| let state = iterator.next() | ||
| for(let i = 0; i < replayStack.length; i++){ | ||
| if(state.done){ | ||
| return fromEffect(die("Something very wrong has happened. Replaying values resulted in a premature end of the generator execution. Provided generator should be pure and perform effects only by yielding them, so that the generator can safely be re-run without side effects.")) |
There was a problem hiding this comment.
Better to make a dedicated Tagged Exception maybe in the GlobalExceptions module
fubhy
pushed a commit
that referenced
this pull request
Jan 1, 2024
Co-authored-by: gcanti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in gcanti/fp-ts#261 (comment) , I came up with a way of replaying generators locally in order to support do notation for stream