Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deviceshifu mqtt and socket customized deviceshifu #938

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Improve deviceshifu mqtt and socket customized deviceshifu #938

merged 5 commits into from
Jul 31, 2024

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Jul 31, 2024 •
edited
Loading

What this PR does / why we need it:
Compare with other deivceshifu, MQTT and Socket are using customized incorrect location, so need to align with others
Will this PR make the community happier?
YES!!
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

- Improve deviceShifu MQTT customized deviceshifu logic
- Improve deviceShifu Socket customized deviceshifu logic 
- remove \n in customized deviceshifu return value

@rhoninl rhoninl changed the title Improve deviceshifu mqtt customized deviceshifu Improve deviceshifu mqtt and socket customized deviceshifu Jul 31, 2024
tomqin93
tomqin93 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 3471a86 into main Jul 31, 2024
12 of 13 checks passed
@tomqin93 tomqin93 deleted the update_deviceshifu_mqtt_customized_deviceshifu branch July 31, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomqin93 tomqin93 tomqin93 approved these changes

@saiyan86 saiyan86 Awaiting requested review from saiyan86 saiyan86 is a code owner

@kris21he kris21he Awaiting requested review from kris21he

Assignees

@tomqin93 tomqin93

@kris21he kris21he

@saiyan86 saiyan86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhoninl @tomqin93 @kris21he @saiyan86