Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tag for release v0.29.0-rc1 #726

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

Kidr1cE
Copy link
Contributor

@Kidr1cE Kidr1cE commented Oct 11, 2023

What this PR does / why we need it:
change tag for release v0.29.0-rc1
Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

change tag for release v0.29.0-rc1

@Kidr1cE Kidr1cE changed the base branch from main to release_v0.29.0 October 11, 2023 05:39
@Kidr1cE
Copy link
Contributor Author

Kidr1cE commented Oct 11, 2023

What this PR does / why we need it: change tag for release v0.29.0-rc1 Will this PR make the community happier? Yes Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

@Kidr1cE Kidr1cE closed this Oct 11, 2023
@Kidr1cE Kidr1cE reopened this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cc64637) 54.88% compared to head (11bba22) 54.70%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release_v0.29.0     #726      +/-   ##
===================================================
- Coverage            54.88%   54.70%   -0.18%     
===================================================
  Files                   23       23              
  Lines                 2283     2283              
===================================================
- Hits                  1253     1249       -4     
- Misses                 915      918       +3     
- Partials               115      116       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit ef5ee5a into release_v0.29.0 Oct 11, 2023
@tomqin93 tomqin93 deleted the local_release_v0.29.0 branch October 11, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants