Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pull request#686 #688

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Fix pull request#686 #688

merged 3 commits into from
Aug 28, 2023

Conversation

Kidr1cE
Copy link
Contributor

@Kidr1cE Kidr1cE commented Aug 28, 2023

Fix pull request #686

updated-dependencies:

  • dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-minor ...

What this PR does / why we need it:
fix pr#686

Will this PR make the community happier?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.27.4 to 0.28.1.
- [Commits](kubernetes/api@v0.27.4...v0.28.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Kidr1cE Kidr1cE changed the title Bump k8s.io/api from 0.27.4 to 0.28.1 Fix pull request#686 Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14% ⚠️

Comparison is base (aa0e98d) 55.07% compared to head (10bf782) 54.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   55.07%   54.94%   -0.14%     
==========================================
  Files          23       23              
  Lines        2277     2277              
==========================================
- Hits         1254     1251       -3     
- Misses        909      911       +2     
- Partials      114      115       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93 tomqin93 merged commit d9431cc into main Aug 28, 2023
@tomqin93 tomqin93 deleted the fix-pr#686 branch August 28, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants