Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mockdeviceName #252

Merged
merged 1 commit into from
Sep 14, 2022
Merged

fix mockdeviceName #252

merged 1 commit into from
Sep 14, 2022

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Sep 14, 2022

What this PR does / why we need it:
Unified mockDevice image name
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 22.60% // Head: 22.60% // No change to project coverage 👍

Coverage data is based on head (e6d6f20) compared to base (8bcf7a1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   22.60%   22.60%           
=======================================
  Files           8        8           
  Lines         836      836           
=======================================
  Hits          189      189           
  Misses        628      628           
  Partials       19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit ae0f7fc into main Sep 14, 2022
@tomqin93 tomqin93 deleted the fix_mockdevice branch September 14, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants