add_telemetry #249
Merged
add_telemetry #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoninl
requested review from
saiyan86,
seanli33056,
tomqin93 and
BtXin
as code owners
Codecov ReportBase: 22.60% // Head: 22.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 22.60% 22.60%
=======================================
Files 8 8
Lines 836 836
=======================================
Hits 189 189
Misses 628 628
Partials 19 19 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tomqin93
requested changes
Sep 13, 2022
BtXin
reviewed
Sep 13, 2022
tomqin93
reviewed
Sep 13, 2022
tomqin93
reviewed
Sep 13, 2022
BtXin
previously approved these changes
Sep 14, 2022
|
LGTM |
seanli33056
approved these changes
Sep 14, 2022
|
LGTM. But we need to configure RBAC on shifu's telemetry service. This can be done in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add telemetry
Will this PR make the community happier?
yes!!!
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: