Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify default_handler_from base => pre protocol #248

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Sep 11, 2022

What this PR does / why we need it:
modify default_handler_from base => pre protocol
Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #248 (4bdb201) into main (abd2141) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   21.85%   22.60%   +0.74%     
==========================================
  Files           8        8              
  Lines         828      836       +8     
==========================================
+ Hits          181      189       +8     
  Misses        628      628              
  Partials       19       19              
Impacted Files Coverage Δ
pkg/deviceshifu/deviceshifuhttp/deviceshifuhttp.go 16.16% <100.00%> (+0.63%) ⬆️
pkg/deviceshifu/deviceshifumqtt/deviceshifumqtt.go 28.57% <100.00%> (+1.03%) ⬆️
...g/deviceshifu/deviceshifuopcua/deviceshifuopcua.go 11.39% <100.00%> (+0.92%) ⬆️
...deviceshifu/deviceshifusocket/deviceshifusocket.go 27.89% <100.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 2f7db41 into main Sep 13, 2022
@tomqin93 tomqin93 deleted the modify_default_handler branch September 13, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants