Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add golangci-lint and github action #241

Merged
merged 17 commits into from
Sep 9, 2022
Merged

add golangci-lint and github action #241

merged 17 commits into from
Sep 9, 2022

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Sep 5, 2022

What this PR does / why we need it:
add golang-cilint and github action
Will this PR make the community happier?
no
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #241 (a432abc) into main (64ac32f) will decrease coverage by 0.17%.
The diff coverage is 12.96%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   22.03%   21.85%   -0.18%     
==========================================
  Files           8        8              
  Lines         826      828       +2     
==========================================
- Hits          182      181       -1     
- Misses        627      628       +1     
- Partials       17       19       +2     
Impacted Files Coverage Δ
...deviceshifu/deviceshifusocket/deviceshifusocket.go 26.89% <3.84%> (ø)
pkg/deviceshifu/deviceshifumqtt/deviceshifumqtt.go 27.53% <5.00%> (ø)
pkg/deviceshifu/deviceshifuhttp/deviceshifuhttp.go 15.53% <5.88%> (ø)
...g/deviceshifu/deviceshifuopcua/deviceshifuopcua.go 10.47% <7.69%> (ø)
...kg/deviceshifu/mockdevice/mockdevice/mockdevice.go 73.80% <57.14%> (-12.68%) ⬇️
...ceshifu/deviceshifuopcua/deviceshifuopcuaconfig.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrLeea-13155bc added 1 comment

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrLeea-13155bc added some comment

pkg/deviceshifu/deviceshifuhttp/deviceshifuhttp_test.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifuhttp/deviceshifuhttp_test.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifumqtt/deviceshifumqtt_test.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifumqtt/deviceshifumqtt_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhoninl rhoninl changed the title add golang-cilint and github action add golangci-lint and github action Sep 8, 2022
@tomqin93 tomqin93 merged commit c2a15b5 into main Sep 9, 2022
@tomqin93 tomqin93 deleted the add-golangcilint branch September 9, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants