Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1122] Add support for HTTP PUT request in deviceShifu HTTP #1124

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

tomqin93
Copy link
Contributor

@tomqin93 tomqin93 commented Feb 3, 2025

What this PR does / why we need it:
This PR adds HTTP PUT request from issue #1122

Will this PR make the community happier?
Yes

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1122

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

- add support for HTTP PUT request
- add test for HTTP PUT request
- properly close HTTP request body

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.20%. Comparing base (6f6cadc) to head (495610b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   33.05%   33.20%   +0.14%     
==========================================
  Files          55       55              
  Lines        4861     4864       +3     
==========================================
+ Hits         1607     1615       +8     
+ Misses       3114     3110       -4     
+ Partials      140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93 tomqin93 merged commit fbf788b into main Feb 3, 2025
17 checks passed
@tomqin93 tomqin93 deleted the issue_1122-http-put-support branch February 3, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support HTTP PUT in deviceShifu HTTP
2 participants