Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate update logic in gateway lwm2m #1092

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Dec 30, 2024

What this PR does / why we need it:
Auto update is same with InActvityMonitor in udpOptions, both of them will send update request with a interval. but the InactivityMonitor have reconnect logic in it, so remove duplicate action autoUpdate to avoid send too many update requrest.
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:
image

Release note:

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.05%. Comparing base (377f225) to head (6e92206).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/gateway/lwm2m/client/lwm2m.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   32.94%   33.05%   +0.11%     
==========================================
  Files          55       55              
  Lines        4878     4861      -17     
==========================================
  Hits         1607     1607              
+ Misses       3131     3114      -17     
  Partials      140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93
Copy link
Contributor

known issue: #1115

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl please sync with main and fix lint issue. The rest looks good

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 19f5b1a into main Jan 26, 2025
16 of 17 checks passed
@tomqin93 tomqin93 deleted the remove_duplicate_update_logic branch January 26, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants