Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reconnect for lwm2m gateway #1075

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Dec 10, 2024

What this PR does / why we need it:
gateway lwm2m don't support reconnect, if connectin is lost, only can reconnect it by restart deployment or pod
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)
    test by local cluste, cut down and restore the network

Special notes for your reviewer:

Release note:

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Project coverage is 33.06%. Comparing base (7af19e4) to head (ff5183a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/gateway/lwm2m/client/lwm2m.go 0.00% 77 Missing ⚠️
pkg/gateway/lwm2m/gatewaylwm2m.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
- Coverage   33.42%   33.06%   -0.36%     
==========================================
  Files          55       55              
  Lines        4808     4875      +67     
==========================================
+ Hits         1607     1612       +5     
- Misses       3061     3124      +63     
+ Partials      140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added some comments

pkg/gateway/lwm2m/client/lwm2m.go Show resolved Hide resolved
pkg/gateway/lwm2m/client/lwm2m.go Outdated Show resolved Hide resolved
pkg/gateway/lwm2m/client/lwm2m.go Outdated Show resolved Hide resolved
pkg/gateway/lwm2m/client/lwm2m.go Outdated Show resolved Hide resolved
pkg/gateway/lwm2m/client/lwm2m.go Show resolved Hide resolved
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 1771453 into main Dec 11, 2024
15 of 17 checks passed
@tomqin93 tomqin93 deleted the add_reconnect_for_lwm2m_gateway branch December 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants