customized lwm2m gateway all settings #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 33.51% 33.63% +0.11%
==========================================
Files 55 55
Lines 4810 4808 -2
==========================================
+ Hits 1612 1617 +5
+ Misses 3059 3053 -6
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
tomqin93
reviewed
Dec 4, 2024
| @@ -115,6 +115,12 @@ type LwM2MSetting struct { | |||
|
|
|||
| // +kubebuilder:default=30 | |||
| PingIntervalSec int64 `json:"pingIntervalSec,omitempty"` | |||
| // +kubebuilder:default=300 | |||
There was a problem hiding this comment.
use https://datatracker.ietf.org/doc/html/rfc7252#section-4.8.2 default 247 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make user can customized all lwm2m gateway settings from edgedevice
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #How is this PR tested
Special notes for your reviewer:
Release note: