Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase LwM2M pingInterval update to main #1064

Merged
merged 1 commit into from
Dec 3, 2024
Merged

rebase LwM2M pingInterval update to main #1064

merged 1 commit into from
Dec 3, 2024

Conversation

tomqin93
Copy link
Contributor

@tomqin93 tomqin93 commented Dec 3, 2024

What this PR does / why we need it:
This PR rebases changes in v0.58.1 to main
Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

- rebase LwM2M ping interval configuration back to main

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (8510408) to head (d373ff5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/gateway/lwm2m/gatewaylwm2m.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   33.54%   33.52%   -0.02%     
==========================================
  Files          55       55              
  Lines        4806     4808       +2     
==========================================
  Hits         1612     1612              
- Misses       3055     3057       +2     
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93 tomqin93 merged commit 539475c into main Dec 3, 2024
15 of 17 checks passed
@tomqin93 tomqin93 deleted the rebase_v0.58.1 branch December 3, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants