Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme to show shifu's value with a diagram #1056

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

saiyan86
Copy link
Contributor

What this PR does / why we need it:

This PR updates the README file to show shifu's value.

Will this PR make the community happier?

Yes. This will make it much easier to understand why developers need to choose shifu.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

@saiyan86 saiyan86 changed the title update readme update readme to show shifu's value Nov 22, 2024
@saiyan86 saiyan86 changed the title update readme to show shifu's value update readme to show shifu's value with a diagram Nov 22, 2024
@saiyan86 saiyan86 requested a review from rhoninl November 22, 2024 05:38
@saiyan86 saiyan86 enabled auto-merge (squash) November 22, 2024 05:38
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.49%. Comparing base (db47f77) to head (983a108).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   33.43%   33.49%   +0.06%     
==========================================
  Files          55       55              
  Lines        4806     4806              
==========================================
+ Hits         1607     1610       +3     
+ Misses       3059     3057       -2     
+ Partials      140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhoninl rhoninl self-requested a review November 22, 2024 05:50
Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saiyan86 saiyan86 requested a review from rhoninl November 22, 2024 06:24
@saiyan86 saiyan86 disabled auto-merge November 22, 2024 06:25
@saiyan86 saiyan86 merged commit db5fbb3 into main Nov 22, 2024
6 checks passed
@saiyan86 saiyan86 deleted the updateReadMe branch November 22, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants