Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve customized deviceshifu doc #316

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Aug 14, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

rename customized deviceshifu instruction name to avoid use number as instruction name

Which issue(s) this PR fixes:

Fixes #

How is this PR tested:

  • unit test
  • e2e test
  • other (please specify)
    documentation no need test

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shifu-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:16am

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 14cb704 into main Aug 14, 2024
3 of 4 checks passed
@tomqin93 tomqin93 deleted the fix_customized_deviceshifu_doc branch August 14, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants