Price change fixes

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+- fixed: Do not exit the price-change daemon when a rate is missing
+- fixed: Make the rates backend configurable.
+- fixed: Send a NACK when we fail to deliver a message.
+
 ## 2.4.0 (2024-12-16)
 
 - added: Validate deviceTokens with a RegExp.

src/daemons/priceChangeDaemon.ts

@@ -18,7 +18,7 @@ runDaemon(async tools => {
 
       // Grab the price:
       const price = await tools.rates.getRate(currencyPair, now)
-      if (price == null) return
+      if (price == null) continue
 
       // Check the triggers:
       await checkPriceChange(tools, eventRow, now, price, 'day')

src/daemons/publishDaemon.ts

@@ -19,9 +19,13 @@ runDaemon(async tools => {
   const consumer = await connections.queue.subscribe(
     { noAck: false },
     message => {
-      handleMessage(connections, message).catch(error => {
+      handleMessage(connections, message).catch(async error => {
+        const nackStatus = await message.nack(true).then(
+          () => '',
+          () => ', nack failed'
+        )
         logger.warn({
-          msg: 'Failed to handle message',
+          msg: 'Failed to handle message' + nackStatus,
           body: message.bodyToString(),
           error
         })

src/db/couchSettings.ts

@@ -27,6 +27,7 @@ const asSettings = asObject({
     ),
     []
   ),
+  ratesServer: asMaybe(asString, 'https://rates2.edge.app'),
 
   // Mode toggles:
   debugLogs: asMaybe(asBoolean, false),

src/util/ratesCache.ts

@@ -1,12 +1,13 @@
 import { asEither, asNull, asObject, asString } from 'cleaners'
 import fetch from 'node-fetch'
 
+import { syncedSettings } from '../db/couchSettings'
+
 export interface RatesCache {
   getRate: (currencyPair: string, date: Date) => Promise<number | null>
   trimCache: (before: Date) => void
 }
 
-const RATES_SERVER = 'https://rates2.edge.app'
 const ROUNDING = 5 * 60 * 1000 // 5 minutes
 
 export function makeRatesCache(): RatesCache {
@@ -49,8 +50,9 @@ async function getFromServer(
   currencyPair: string,
   date: Date
 ): Promise<number | null> {
+  const { ratesServer } = syncedSettings.doc
   const response = await fetch(
-    `${RATES_SERVER}/v2/exchangeRate?currency_pair=${currencyPair}&date=${date.toISOString()}`
+    `${ratesServer}/v2/exchangeRate?currency_pair=${currencyPair}&date=${date.toISOString()}`
   )
   const json = await response.json()
   const { exchangeRate } = asRateReply(json)