NowNodes fixes #412
Merged
NowNodes fixes #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket close event has a useful status code, as defined in rfc6455 section 7.4.1. Include that, as well as improving our error string handling.
swansontec
force-pushed
the
william/nownodes-fixes
branch
from
04a53e6 to
1e17239
Compare
samholmes
approved these changes
Aug 29, 2024
| : trackedError instanceof Error | ||
| ? trackedError | ||
| : new Error(String(trackedError)) | ||
| log.warn(`onSocketClose with server ${uri}: ${code} ${errObj.message}`) |
There was a problem hiding this comment.
Should we include reason: string?
There was a problem hiding this comment.
No, it's blank in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none