Fix for "Missing processor address" error #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Apr 22, 2024
New baselet upgrade removes the requirement for a partition argument for `dumpData` on each baselet type. If a partition arg is not provided then all data in the baselet instance is returned.
If scriptPubkeyByPath is written to before addressByScriptPubkey, there is a chance that the write to addressByScriptPubkey fails or is interrupted, causing the processor data to be incorrect (an index on data that was never written). This appears to the user as an infamous "Missing processor address...during initialization" error message. We hopefully fix the issue and error for good with this change. The change includes moving the write to scriptPubkeyByPath at the end of the `saveAddress` processor routine. We do this with a update variable which we declare at the start of the routine and define it only when the update to the scriptPubkeyByPath table is necessary. In addition to this, we reworked some of the control-flow of this routine and modified the conditions in the control-flow for better readability. It's important this code is maintainable and easy to reason about.
samholmes
force-pushed
the
sam/investigate-missing-processor-address-error
branch
from
8e1af16 to
83c1412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none