Merge pull request #391 from EdgeApp/sam/rbf-fixes

Add missing check for currency RBF capabilities in accelerate method
EdgeApp · Nov 10, 2023 · ba799cb · ba799cb
2 parents 5bbdb93 + eea3add
commit ba799cb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- changed: Disabled RBF for Litecoin
+- fixed: Respect `canReplaceByFee` flag from currency info in engine `accelerate` function
+
 ## 2.5.0 (2023-10-31)
 
 - added: `accelerate` method to `UtxoEngine` for RBF support.

diff --git a/src/common/utxobased/engine/makeUtxoEngine.ts b/src/common/utxobased/engine/makeUtxoEngine.ts
@@ -141,6 +141,9 @@ export async function makeUtxoEngine(
 
   const engine: EdgeCurrencyEngine = {
     async accelerate(edgeTx: EdgeTransaction): Promise<EdgeTransaction | null> {
+      const { canReplaceByFee = false } = currencyInfo
+      if (!canReplaceByFee) return null
+
       // Get the replaced transaction from the processor:
       const replacedTxid = edgeTx.txid
       const [replacedTx] = await processor.fetchTransactions({

diff --git a/src/common/utxobased/info/litecoin.ts b/src/common/utxobased/info/litecoin.ts
@@ -27,7 +27,7 @@ export const currencyInfo: EdgeCurrencyInfo = {
     ],
     enableCustomServers: false
   },
-  canReplaceByFee: true,
+  canReplaceByFee: false,
   customFeeTemplate: [
     {
       type: 'nativeAmount',