Remove missing servers for internal servers list

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- changed: Remove Blockbook servers from persisted internal servers list when updating this list from payload/default servers.
+
 ## 3.5.0 (2025-01-15)
 
 - added: Implement `updateInfoPayload` for `EdgeCurrencyEngine` to get currency info updates from info-server.

src/common/plugin/PluginState.ts

@@ -183,6 +183,8 @@ export function makePluginState(settings: PluginStateSettings): PluginState {
     },
 
     async refreshServers(updatedCustomServers?: string[]): Promise<void> {
+      const serverList = getSelectedServerList()
+
       let newServers: string[]
       if (serverCache.enableCustomServers) {
         newServers =
@@ -200,9 +202,17 @@ export function makePluginState(settings: PluginStateSettings): PluginState {
               infoPayloadServers
             : // Use the default servers from info file as final fallback
               defaultSettings.blockbookServers
+
+        // Remove any server that's not included in the internal servers list.
+        // This is so we can control removal of poor servers from the
+        // info-server in real-time.
+        const missingServers = Object.keys(serverList).filter(
+          server => !newServers.includes(server)
+        )
+        serverScores.removeServers(serverList, missingServers)
       }
 
-      serverScores.serverScoresLoad(getSelectedServerList(), newServers)
+      serverScores.serverScoresLoad(serverList, newServers)
       await saveServerCache()
 
       // Tell the engines about the new servers:

src/common/plugin/ServerScores.ts

@@ -343,4 +343,11 @@ export class ServerScores {
 
     return selectedServers
   }
+
+  removeServers(servers: ServerList, serverUrls: string[]): void {
+    for (const serverUrl of serverUrls) {
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+      delete servers[serverUrl]
+    }
+  }
 }