Skip to content

Commit

Permalink
Merge pull request #403 from EdgeApp/sam/dev-server-port
Browse files Browse the repository at this point in the history
Change webpack dev-server port from 8081 to 8084
  • Loading branch information
samholmes authored May 29, 2024
2 parents f82fe53 + 7349271 commit 39631d3
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- changed: Changed webpack dev server port to 8084 to resolve conflict with metro's 8081 usage.

## 3.0.0 (2024-05-14)

- added: Added blockbook-nownode server configs to BTC, BCH, DASH, DGB, GRS, LTC, and FIRO
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ The bundle located in `dist/edge-currency-plugins.js` will automatically registe
```
If you want to debug this project, run `yarn start` to start a Webpack server,
and then adjust your script URL to http://localhost:8081/edge-currency-plugins.js.
and then adjust your script URL to http://localhost:8084/edge-currency-plugins.js.
### React Native
Expand Down
2 changes: 1 addition & 1 deletion src/react-native.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { EdgeCurrencyPluginsModule } = NativeModules
const { sourceUri } = EdgeCurrencyPluginsModule.getConstants()

export const pluginUri = sourceUri
export const debugUri = 'http://localhost:8081/edge-currency-plugins.js'
export const debugUri = 'http://localhost:8084/edge-currency-plugins.js'

export interface EdgeCurrencyPluginIoOptions {
readonly memletConfig?: MemletConfig
Expand Down
6 changes: 3 additions & 3 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ const debug = process.env.WEBPACK_SERVE

// Try exposing our socket to adb (errors are fine):
if (process.env.WEBPACK_SERVE) {
console.log('adb reverse tcp:8081 tcp:8081')
exec('adb reverse tcp:8081 tcp:8081', () => {})
console.log('adb reverse tcp:8084 tcp:8084')
exec('adb reverse tcp:8084 tcp:8084', () => {})
}

const bundlePath = path.resolve(
Expand All @@ -22,7 +22,7 @@ module.exports = {
devServer: {
allowedHosts: 'all',
hot: false,
port: 8081,
port: 8084,
static: bundlePath
},
entry: './src/index.ts',
Expand Down

0 comments on commit 39631d3

Please sign in to comment.