Detect chainIds in eip681 URIs #882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Jan 15, 2025
src/ethereum/EthereumTools.ts
Outdated
| @@ -205,6 +206,21 @@ export class EthereumTools implements EdgeCurrencyTools { | |||
| } | |||
| address = contractAddress | |||
|
|
|||
| // Split the address to get the chainId according to EIP-681 | |||
| if (address.includes('@')) { | |||
There was a problem hiding this comment.
Does this allow using an Ethereum: uri with an L2 like optimism if and only if the chainId exists?
peachbits
force-pushed
the
matthew/eip681-chainId
branch
from
96cb5e2 to
8cb7297
Compare
swansontec
approved these changes
Jan 16, 2025
| throw new Error( | ||
| 'chainId must be present when using ethereum: prefix on a non-ethereum network' | ||
| ) | ||
| } else if (address.includes('@')) { |
There was a problem hiding this comment.
This else isn't needed, since the previous if can only throw. Un-indenting this block would make it more obvious that it runs in every case, assuming we pass the error check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none