Integrate Seen Tx Checkpoint API #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/seenTxCheckpoint
branch
from
84ce95f to
aaf2474
Compare
swansontec
approved these changes
Jan 8, 2025
samholmes
force-pushed
the
sam/seenTxCheckpoint
branch
4 times, most recently
from
0e6bfcc to
6e0856a
Compare
swansontec
approved these changes
Jan 15, 2025
src/tezos/TezosEngine.ts
Outdated
| @@ -387,13 +386,13 @@ export class TezosEngine extends CurrencyEngine< | |||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |||
| this.addToLoop('checkTransactionsInnerLoop', TRANSACTION_POLL_MILLISECONDS) | |||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |||
| super.startEngine(opts) | |||
| super.startEngine() | |||
There was a problem hiding this comment.
This could be await super.startEngine(), and then we can delete the comment above.
samholmes
force-pushed
the
sam/seenTxCheckpoint
branch
from
6e0856a to
53b7ee9
Compare
samholmes
force-pushed
the
sam/seenTxCheckpoint
branch
from
53b7ee9 to
5224e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none