Add Filecoin FEVM #662

samholmes · 2023-11-08T01:10:53Z

Now that the call signature for EthereumNetwork.multicastRpc matches
NetworkAdaptor.multicastRpc, there is no need for the case handling
for each method.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205654034220700

swansontec

Thanks for cleaning this up. Can you move the Filecoin commits to the end of the pull request? That way we just have some clean refactoring, followed by a new currency that uses the fresh features.

swansontec · 2023-11-09T21:59:45Z

src/ethereum/info/filecoinFevmCalibrationInfo.ts

+  // {
+  //   filfoxUrl: 'https://filfox.info/api/v1',
+  //   filscanUrl: 'https://api-v2.filscan.io/api/v1',
+  //   hdPathCoinType: 461,


hdPathCoinType already exists below.

src/ethereum/info/filecoinFevmCalibrationInfo.ts

swansontec · 2023-11-09T22:05:12Z

src/ethereum/info/filecoinFevmCalibrationInfo.ts

+  },
+
+  async getInnerPlugin() {
+    /* webpackChunkName: "filecoinfevmcalibration" */


Delete this webpackChunkName. The ethereumInfo file defines the chunk name for the Ethereum sources, so this line will conflict with that.

I thought ethereumInfo was a peer of all the other EVM info files. Looks like you're right that those other info files don't have the webpackChunkName set for them, but I'm curious as to why? Wouldn't it make sense to chunk each info file as they're slurped up by ethereumInfos.ts (the index file of all the other EVM infos, not the info file for Ethereum)?

The webpackChunkName comment gives the final name of the file being imported in this import() expression. So we are saying that, once bundled on disk, the "EthereumTools.ts" file should be called "ethereum-[hash].js". This bundled file will include "EthereumTools.ts" (of course), but also any unique transitive dependencies not shared with other chunks. So we would expect files like "EthereumEngine.ts" to also get bundled into "ethereum-[hash].js", along with some SDK bits from node_modules.

This is completely unnecessary on a technical level. Nobody is going to see the file names that get embedded into the app, and filenames don't matter to the WebView either. However, it does sometimes help with debugging packaging problems and with better stack traces, so it's worth doing.

src/ethereum/info/filecoinFevmInfo.ts

swansontec · 2023-11-09T22:51:25Z

src/ethereum/EthereumNetwork.ts

-  [method in UpdateMethods]: Array<
-    (...args: any[]) => Promise<EthereumNetworkUpdate>
-  >
+type NetworkAdaptorUpdateMethod = 'blockheight' | 'nonce' | 'tokenBal' | 'txs'


Should this be keyof NetworkAdaptor, instead of hard-coding it?

Later in the PR, not all keys are update methods. Perhaps I can couple the types though using TS utility types.

Oh, that makes sense.

src/ethereum/EthereumNetwork.ts

src/ethereum/networkAdaptors/types.ts

src/ethereum/networkAdaptors/FilfoxAdaptor.ts

swansontec

Excellent work!

This makes the method names clearer that they're are retrieval methods.

Now that the call signature for `EthereumNetwork.multicastRpc` matches `NetworkAdaptor.multicastRpc`, there is no need for the case handling for each method.

swansontec requested changes Nov 10, 2023

View reviewed changes

swansontec changed the title ~~Add Filecoin EVEM~~ Add Filecoin FEVM Nov 10, 2023

samholmes force-pushed the sam/filecoin-fevm branch from 9a8c421 to dfd9ad8 Compare November 10, 2023 23:31

swansontec approved these changes Nov 10, 2023

View reviewed changes

samholmes force-pushed the sam/filecoin-fevm branch 2 times, most recently from bcb0a9a to 88fd389 Compare November 13, 2023 23:12

samholmes enabled auto-merge November 13, 2023 23:12

samholmes disabled auto-merge November 13, 2023 23:24

samholmes added 21 commits November 13, 2023 15:38

Removed unsafeBroadcastTx configuration for Filecoin

1ad9de1

Added support to send to 0x addresses for Filecoin plugin

e542c0a

Remove duplicate identifiers in EthereumNetwork

51d8044

Fix explicit-function-return-type lint errors in EthereumNetwork

ccb50ed

Fix strict-boolean-expressions lint errors in EthereumNetwork

b5c692c

Fix invalid typescript syntax

da5ef52

Fix typescript-eslint/default-param-last in EthereumNetwork

a6ad67c

Fix QueryFuncs type in EthereumNetwork

535e81d

Create a separate method for checking multiple token balances

84372f3

Refactor QueryFuncs into NetworkAdapter type

377e887

Factor out overloaded multicastServers impl. to respective methods

9e10ddc

Separate Ethscan and RPC blockheight methods

a6e0920

Add type parameter to promiseAny

329d820

Factor out overloaded multicastServers impl. for broadcastTx

9d12f7e

Factor out network specific methods to NetworkAdapter interfaces

97a5f2b

Rename methods on NetworkAdapter

09c451e

This makes the method names clearer that they're are retrieval methods.

Consolidate server config to a new NetworkAdapterConfig type

5373b93

Rename multicastServers to multicastRpc to reflect it's new purpose

5c5d652

Abstract multi-server requests to two protected utility methods

ae46fa6

Change multicastRpc argument signature to match RPC call signature

61335ac

Collapse multicastRpc method implementation cases

e911172

Now that the call signature for `EthereumNetwork.multicastRpc` matches `NetworkAdaptor.multicastRpc`, there is no need for the case handling for each method.

samholmes force-pushed the sam/filecoin-fevm branch from 88fd389 to cbe08ea Compare November 13, 2023 23:38

samholmes enabled auto-merge November 13, 2023 23:38

Filecoin FEVM currencies

786e371

samholmes force-pushed the sam/filecoin-fevm branch from cbe08ea to 786e371 Compare November 14, 2023 18:57

samholmes merged commit 8ca9e9a into master Nov 14, 2023
3 checks passed

samholmes deleted the sam/filecoin-fevm branch November 14, 2023 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Filecoin FEVM #662

Add Filecoin FEVM #662

samholmes commented Nov 8, 2023 •

edited

Loading

swansontec left a comment

swansontec Nov 9, 2023

swansontec Nov 9, 2023

samholmes Nov 10, 2023

swansontec Nov 10, 2023 •

edited

Loading

swansontec Nov 9, 2023

samholmes Nov 10, 2023

swansontec Nov 10, 2023

swansontec left a comment

Add Filecoin FEVM #662

Add Filecoin FEVM #662

Conversation

samholmes commented Nov 8, 2023 • edited Loading

CHANGELOG

Dependencies

Description

swansontec left a comment

Choose a reason for hiding this comment

swansontec Nov 9, 2023

Choose a reason for hiding this comment

swansontec Nov 9, 2023

Choose a reason for hiding this comment

samholmes Nov 10, 2023

Choose a reason for hiding this comment

swansontec Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

swansontec Nov 9, 2023

Choose a reason for hiding this comment

samholmes Nov 10, 2023

Choose a reason for hiding this comment

swansontec Nov 10, 2023

Choose a reason for hiding this comment

swansontec left a comment

Choose a reason for hiding this comment

samholmes commented Nov 8, 2023 •

edited

Loading

swansontec Nov 10, 2023 •

edited

Loading