XRP EdgeTxActionSwap Direction Fix #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
paullinator
approved these changes
Nov 2, 2023
src/ripple/RippleEngine.ts
Outdated
| } else { | ||
| const builtinToken = this.builtinTokens[tokenId] | ||
| if (builtinToken == null) return | ||
| takerDenom = this.builtinTokens[tokenId]?.denominations[0] |
There was a problem hiding this comment.
change to
takerDenom = builtInToken.denominations[0]
This will fix typescript issue
src/ripple/RippleEngine.ts
Outdated
| if (takerDenom == null) { | ||
| this.error(`parseRippleDexTxAmount: Unknown denom ${currency}`) | ||
| // Shouldn't happen |
There was a problem hiding this comment.
This should be able to be removed after the change above
Fix for only the bugged src/dest direction fix. Partial fill amounts that happen after the initial order tx will require a future fix and api change.
Jon-edge
force-pushed
the
jon/fix/xrp-txaction
branch
from
6126a12 to
507a5ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for only the bugged src/dest direction fix.
Partial fill amounts that happen after the initial order tx will require
a future fix and api change.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none