Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI for working with plugins #649

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add a CLI for working with plugins #649

merged 1 commit into from
Nov 7, 2023

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented Oct 19, 2023

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Copy link
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a command that wipes out local storage. Besides that, I had other feedback that is kind of moot since I thought interactive mode was the only mode (I clearly didn't read the README)

cli.register(Builtins.HelpCommand)
cli.register(Builtins.VersionCommand)
cli.register(CreateKey)
cli.register(DisableToken)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeleteToken appears to be missing

Copy link
Contributor Author

@swansontec swansontec Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! So I did implement it, but forgot to register it.

@swansontec swansontec force-pushed the william/cli branch 5 times, most recently from c88e014 to 8351e59 Compare November 7, 2023 23:08
@swansontec swansontec enabled auto-merge November 7, 2023 23:25
@swansontec swansontec merged commit ab35b7a into master Nov 7, 2023
@swansontec swansontec deleted the william/cli branch November 7, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants