Use transaction type 0 for currencies which do not support EIP-1559

EdgeApp · Nov 9, 2023 · 63ed43a · 63ed43a
1 parent c98ca8e
commit 63ed43a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- fixed: Use transaction type 0 (legacy transactions) currencies which do no support EIP-1559
+
 ## 2.11.0 (2023-11-08)
 
 - added: Add THORChain (RUNE)

diff --git a/src/ethereum/EthereumEngine.ts b/src/ethereum/EthereumEngine.ts
@@ -1182,7 +1182,7 @@ export class EthereumEngine extends CurrencyEngine<
     const common = Common.custom(chainParams)
 
     // Translate legacy transaction types to EIP-1559 transaction type
-    const txType = this.networkInfo.supportsEIP1559 === true ? 2 : 1
+    const txType = this.networkInfo.supportsEIP1559 === true ? 2 : 0
     // Translate legacy transaction types gas params to to EIP-1559 params
     const gasFeeParams = await getFeeParamsByTransactionType(
       txType,

diff --git a/src/ethereum/fees/ethMiningFees.ts b/src/ethereum/fees/ethMiningFees.ts
@@ -301,7 +301,7 @@ export async function getFeeParamsByTransactionType(
   gasPrice: string,
   fetchBaseFeePerGas: () => Promise<string | undefined>
 ): Promise<GasParams> {
-  if (transactionType === 1) {
+  if (transactionType < 2) {
     return { gasPrice }
   } else {
     const baseFeePerGas = await fetchBaseFeePerGas()