Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

created my profile to be added #1831

Merged
merged 7 commits into from
Oct 1, 2022

Conversation

SanDiego2049
Copy link
Member

@SanDiego2049 SanDiego2049 commented Sep 30, 2022

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Sep 30, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions
Copy link
Contributor

Welcome @SanDiego2049! Thank you so much for your first pull request!

@github-actions github-actions bot added waiting-for-reviewers ✍ chore: profile This label will be added on PR with request of Data json addition LGTM hacktoberfest-invalid labels Sep 30, 2022
@github-actions
Copy link
Contributor

Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🎉

@SanDiego2049
Copy link
Member Author

Thanks for contributing! 🎉

do i close the pr now for it to be final?

@imlakshay08
Copy link
Member

Thanks for contributing! tada

do i close the pr now for it to be final?

You do not need to close the PR. Maintainers will merge the PR first and then it will be closed on it's own

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me! 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants