Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joss review fixes #115

Merged
merged 8 commits into from
Nov 5, 2021
Merged

Joss review fixes #115

merged 8 commits into from
Nov 5, 2021

Conversation

kescobo
Copy link
Member

@kescobo kescobo commented Nov 4, 2021

Working on suggestions from reviewers.

@kescobo kescobo added docs I/O Related to input / output of data labels Nov 4, 2021
@kescobo kescobo changed the title Aguang review Joss review fixes Nov 4, 2021
@kescobo
Copy link
Member Author

kescobo commented Nov 5, 2021

Oh right, this is why I didn't add this example before, because dealing with dependencies for Documenter gave me a migraine :(

@kescobo kescobo merged commit 64dc7d9 into main Nov 5, 2021
@kescobo kescobo deleted the aguang-review branch November 5, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs I/O Related to input / output of data
Projects
None yet
1 participant