Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONL- 6908] GA events are not recorded by the GA servers #56

Merged
merged 4 commits into from
Oct 4, 2022
Merged

[ONL- 6908] GA events are not recorded by the GA servers #56

merged 4 commits into from
Oct 4, 2022

Conversation

corinaper
Copy link
Contributor

excluded the value when sending an event to GA

@corinaper corinaper requested a review from mcibique as a code owner October 3, 2022 16:25
mcibique
mcibique approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@mcibique mcibique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to bump up the version in package.json before merging to master.

@corinaper corinaper merged commit b844e42 into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcibique mcibique mcibique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corinaper @mcibique