Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FluidLite #74

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Add FluidLite #74

merged 1 commit into from
Aug 21, 2020

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Jun 16, 2020 •
edited
Loading

  • Add vcpkg (Windows)

carstene1ns
carstene1ns reviewed Jun 16, 2020
View reviewed changes
shared/packages.sh Outdated
ver=bce54560975bf1d69569314f46d027b06307ca1a
FLUIDLITE_URL="https://github.com/divideconcept/$lib/archive/$ver.zip"
FLUIDLITE_DIR="$lib-$ver"
FLUIDLITE_ARGS="-DFLUIDLITE_BUILD_STATIC=ON -DFLUIDLITE_BUILD_STATIC=OFF"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on or off? :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I meant shared xD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly this still compiled. Likely because Generic architecture is used that had no shared library support /g/

@Ghabry
Copy link
Member Author

Ghabry commented Aug 18, 2020

I'm almost ready to submit it to vcpkg but first I have to upstream a buildfix because there is a hard dependency on libm. A library not existant on Windows. The lib author is usually fast with merging.

@fdelapena
Copy link
Contributor

fdelapena commented Aug 18, 2020 •
edited
Loading

The lib author is usually fast with merging.

It took around 30 minutes since your comment here 🎉.

@Ghabry Ghabry marked this pull request as ready for review August 19, 2020 16:56
@Ghabry
Copy link
Member Author

Ghabry commented Aug 19, 2020 •
edited
Loading

I have to wait for the approval of the vcpkg port. Otherwise this is ready.
microsoft/vcpkg#13006

I havn't tested how good the SF3 support is (soundfont with OGG), at least SF2 will work.

@fdelapena
Copy link
Contributor

vcpkg merged the package 🎉

@fdelapena fdelapena merged commit b62b3d8 into EasyRPG:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

@mateofio mateofio mateofio approved these changes

@carstene1ns carstene1ns Awaiting requested review from carstene1ns

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ghabry @fdelapena @mateofio @carstene1ns