Adding in more statistics into the client #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to make PR for the same changes (the ACK Rate/stats), as I have forked the repository to add this myself. This is a really useful statistic if you have subscribers doing manual acknowledgments! |
micdenny
requested review from
luigiberrettini,
micdenny,
Pliner and
zidad
as code owners
micdenny
requested changes
Mar 15, 2021
| @@ -4,6 +4,8 @@ namespace EasyNetQ.Management.Client.Model | |||
| { | |||
| public class MessageStats | |||
| { | |||
| public Int64 Ack { get; set; } | |||
There was a problem hiding this comment.
please use long instead of Int64
zidad
approved these changes
Mar 16, 2021
WadeTheFade
pushed a commit
to WadeTheFade/EasyNetQ.Management.Client
that referenced
this pull request
Mar 23, 2021
Merged
|
Fixed in #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are extra statistics available in the Rabbit API and they are useful in monitoring how long a message has been in the queue and some additional ACK stats