merge #1
Merged
merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [faker](https://github.com/faker-ruby/faker) from 2.12.0 to 2.13.0. - [Release notes](https://github.com/faker-ruby/faker/releases) - [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md) - [Commits](faker-ruby/faker@v2.12.0...v2.13.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [autoprefixer-rails](https://github.com/ai/autoprefixer-rails) from 9.8.2 to 9.8.4. - [Release notes](https://github.com/ai/autoprefixer-rails/releases) - [Changelog](https://github.com/ai/autoprefixer-rails/blob/master/CHANGELOG.md) - [Commits](ai/autoprefixer-rails@9.8.2...9.8.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Coming from other languages, it's tempting to use `protected` in Ruby. However this keyword has different nuanced in Ruby and is generally discouraged. It should only be used for methods required for comparators and operators. None of the methods marked as `protected` here fall into this category, so I think they should be marked `private` instead.
In #1618, we removed the explicit include of `jquery_ujs` as it should no longer be necessary. Alas, this broke the ability to destroy items. This wasn't caught by the tests because Capybara tries to be clever with these links, sending the `DELETE` directly instead of clicking on the link. We disable this here and switch the specs to use the JS driver so that we're actually testing the functionality (it can't pass without). Adding the include of `jquery_ujs` solves this for now, unblocking us from having a release for lots of other features and allows us to revisit this problem again (in a way that we'll catch it this time!). Fixes #1643.
If you clone the project and try to start the app, it'll fail with: ``` No such file or directory @ rb_sysopen - /Users/nickcharlton/projects/administrate/tmp/pids/server.pid (Errno::ENOENT) ``` Rails doesn't seem to be able to create this path (perhaps because it's really running `spec/example_app`?) so let's just make sure it's there already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.