feat(http): Add ability to abort a request #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
force-pushed
the
feat/abort
branch
from
17da372 to
71ad174
Compare
mathieucarbou
force-pushed
the
feat/abort
branch
from
3427dc4 to
2496f38
Compare
me-no-dev
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to abort a request.
Tested that with autocannon, 16 or 48 // workerrs, works fine.
The idea is to provide the capability to the user (and us also) to reset the connection in case something has to be stopped now, i.e. bad allocation.
Currently, the use had to do:
request->client()->abort()which is wrong because out of the scope of the request object (_sent and _paused flags should be correctly handled)