[BUG] Crash after client disconnect from Server-Sent-Events

[gsicilia82]

Hello and thank you for your great work. Because I found also the solution for the bug, hopefully this short description is enough:
I wanted to switch from Websockets to SSE. However, I encountered an issue in release v3.6.2: If I disconnect a client, the esp32s3 crashs in this function:

void AsyncEventSource::_handleDisconnect(AsyncEventSourceClient *client) {
  if (_disconnectcb) {
    _disconnectcb(client);
  }
#ifdef ESP32
  std::lock_guard<std::mutex> lock(_client_queue_lock);
#endif
  for (auto i = _clients.begin(); i != _clients.end(); ++i) {
    if (i->get() == client) {
      _clients.erase(i);
    }
  }
  _adjust_inflight_window();
}

Issue and simple fix:
By erasing an element from _clients the iterator becomes "unusable". Therefore it is necessary to break the loop after erase:

void AsyncEventSource::_handleDisconnect(AsyncEventSourceClient *client) {
  if (_disconnectcb) {
    _disconnectcb(client);
  }
#ifdef ESP32
  std::lock_guard<std::mutex> lock(_client_queue_lock);
#endif
  for (auto i = _clients.begin(); i != _clients.end(); ++i) {
    if (i->get() == client) {
      _clients.erase(i);
     break;
    }
  }
  _adjust_inflight_window();
}

[mathieucarbou]

thanks! will open a fix pr later.

@vortigont : FYI ;-)