-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for CESM2 thetao olev units from cm to m #888
Conversation
Standard name should be 'depth' in this case: "depth_coord": {
"standard_name": "depth",
"units": "m",
"axis": "Z",
"long_name": "ocean depth coordinate",
"climatology": "",
"formula": "",
"must_have_bounds": "yes",
"out_name": "lev",
"positive": "down",
"requested": "",
"requested_bounds": "",
"stored_direction": "increasing",
"tolerance": "",
"type": "",
"valid_max": "12000.0",
"valid_min": "0.0",
"value": "",
"z_bounds_factors": "",
"z_factors": "",
"bounds_values": "",
"generic_level_name": "olevel"
} |
nice, cheers Saskia! |
hokeydokey @sloosvel I have now added |
This fix is setting the standard name fine and the proper units for the points of the depth coord as well. But the bounds are also getting converted and do not quite match the points:
Maybe they should be scaled back? Since they originally had the right values but wrong units. |
I will have a look at this right now. Would you mind if I push directly to this branch @valeriupredoi? |
@schlunma @valeriupredoi if it can be of any help I worked with this dataset as well and I figured out one possible fix (along with more general issues about depth coordinates) in 1464c52. Further changes are also available in branch |
@tomaslovato Nice! I really like the idea of specifying a fix for every variable in a given table! I will open a new issue so it's more visible. We can continue the discussion there. |
Superseded by #1095. |
* add cmor variables table in the check of fixes classes (#1069) (cherry picked from commit 0837102) * add ocean depth shared fix and cesm2 dataset fix for depth (#1069, #888) (cherry picked from commit 1464c52) * Added units test for mip-level fixes * Added units test for fix_depth_coord * Update cesm2.py Co-authored-by: Tomas Lovato <[email protected]>
As described in #859 and its older sister #515 CESM2
thetao
has generic vertical levelolev
incm
instead ofm
. Questions before we go further with this:standard_name
at all?Before you start, please read our contribution guidelines.
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #issue_number