Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mocked geopy.geocoders.Nominatim to avoid ReadTimeoutError #2005

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Apr 14, 2023

Description

Use a mocked version of geopy.geocoders.Nominatim to avoid ReadTimeoutError.

Closes #1982


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2005 (3243947) into main (435ade0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         236      236           
  Lines       12438    12438           
=======================================
  Hits        11542    11542           
  Misses        896      896           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool! And pytest-ed the old class too, cheers @schlunma

@valeriupredoi
Copy link
Contributor

excellent, gents @schlunma and @bouweandela - gonna go do some clean up now in light of this 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants