Added custom CMOR tables used for EMAC CMORizer #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1599 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 201 201
Lines 10676 10676
=======================================
Hits 9715 9715
Misses 961 961 Continue to review full report at Codecov.
|
remi-kazeroni
approved these changes
May 30, 2022
axel-lauer
requested changes
May 31, 2022
There was a problem hiding this comment.
I looked through the plots produced by the EMAC example recipe recipe_emac_new.yml and most things look good - as far as I can tell. There are, however, a few items that might need to be double-checked:
- map of precip (given in kg/m2/s): the color scale ranges from 0-10, i.e. the plot is empty and evaluation is not possible.
- map of zg at 500 hPa: the values over Antarctica and over Greenland look very strange, I would expect the values to range somewhere between 5000 and 6000 m but not between 0 and 3000 m as in the plot.
- time series of surface pressure: assuming that the values shown are global mean values, the absolute values and the variability look wrong
axel-lauer
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the custom CMOR tables used for the EMAC CMORizer to reduce the size of #1554.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: