Fix longitude latitude confusion in extract_trajectory preprocessor

[ledm]

A minor edit to extract_trajectory, where the latitude and longitude interface was backwards.

Description

Partially addresses #1137.

Link to documentation:

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[valeriupredoi]

good catch! isn't there a test as well that will need to be changed? or you used identical lat and lon points in the test 😁

[ledm]

The test is:

    def test_extract_trajectory(self):
        """Test to extract a trajectory from a (3, 2, 2) cube."""
        result = extract_trajectory(self.grid_3d, [1.5, 2.5], [2., 2.], 2)
        expected = np.ones((3, 2))
        self.assert_array_equal(result.data, expected)

So it shouldn't fail as it's only effectively comparing the shape of the outputs. Whether that is a good enough unit test should like be another issue/PR!

[valeriupredoi]

OK, it's a decent test, given that the numerical data parameters are tested for (cows vs bulls or bulls vs cows is a different matter, the test is happy as long as they're of the same shape then). I'm merging this if you don't need to get more stuff done to it 👍

[ledm]

Thanks V. Randomly, while I uncovered this bug in my local version of the code, I did all the editing and merging for this PR in github without ever having a local copy of this branch. It is a great method to quickly correct bugs.

[valeriupredoi]

yes but be careful since some tests don't run on the pure github edited branch and only get run when merged onto main so it's good to do the bugfixes locally so you can run all the tests and see if there are issues before merging into main

[bouweandela]

@ledm @valeriupredoi I'm just reviewing our changelog for v2.3 and I'm a bit disappointed by what you came up with as a title for this change. From our contribution guidelines:

The titles and labels of pull requests are used to compile the Changelog, therefore it is important that they are easy to understand for people who are not familiar with the code or people in the project. Descriptive pull request titles also makes it easier to find back what was changed when, which is useful in case a bug was introduced.

Could you please put in a bit more effort next time? 🙏

[ledm]

Sorry, that was the title github generated. I'll change it now, post hoc.