-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for uas variable of the MCM_UA_1_0 dataset #1102
Conversation
@remi-kazeroni and @LisaBock please ping me when you change your various fixes PRs from Draft to RfR - these things are easy to review and I'll merge them very quickly 👍 |
@valeriupredoi thanks a lot for offering your help for the review of the fixes 👍 We'll mark them RfR asap. This one is ready. Just to let you know, I had a seg fault on circleci with the latest commit but it disappeared simply by rerunning the tests 🍺 |
yes, these segfaults are creeping up again, and more alarmingly for the tests that we run in sequential mode, which shouldn't happen, I'll have to look at those again imminently 🍺 |
|
||
Returns | ||
------- | ||
iris.cube.CubeList | ||
iris.cube.Cube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're technically returning a list of one cube, but still a list so the API is incorrect, maybe change with list \n list of [cube]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review @valeriupredoi 👍 Is it fine now? I applied the same suggestion to the tas
fix above, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, cheers @remi-kazeroni 🍺
Description
Fix for the 10m height missing for
uas
Closes #1101
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: