Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for the sake of demo PR #1

Closed
wants to merge 1 commit into from
Closed

Changes for the sake of demo PR #1

wants to merge 1 commit into from

Conversation

billsacks
Copy link
Member

@billsacks billsacks commented Apr 23, 2020 •
edited
Loading

This PR is for demonstration purposes only.

There is a checklist in the body:

  • (optional) Do a task suggested in the body
  • Do another task suggested in the body

After some more text, there is another checklist:

  • Do a task from the body's second checklist

billsacks
billsacks commented Apr 23, 2020
View reviewed changes
Copy link
Member Author

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my line comments, please also:

  • Add a section on Demo deletions

README.md

## Demo additions

This change is just for the sake of making a demo PR.
Copy link
Member Author

@billsacks billsacks Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the following changes to this line:

  • (optional) Please change "just" to "only"
  • Please change "PR" to "Pull Request"

@billsacks
Copy link
Member Author

billsacks commented Apr 23, 2020 •
edited
Loading

PR comments can also include checklist items

  • I should do this
  • I should do that

@billsacks
Copy link
Member Author

Closing this PR that was for demonstration purposes only.

@billsacks billsacks closed this Apr 23, 2020
@billsacks billsacks deleted the demo_branch branch April 23, 2020 19:34
@ESMCI ESMCI locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@billsacks