Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand capability to exclude files from build using .exclude #4302

Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Sep 12, 2022

Updates in this PR expand the capability of using an optional .exclude
file to list files in the sub-tree to skip during compilation. That
feature was originally submitted and merged as #4180 for use with
GEOS-Chem in CESM. A limitation of the feature was recently
discovered when a second .exclude file was added for use with HEMCO.
The content of only one of the files was excluded during build.

This PR features the following improvements in using .exclude:

  1. Using more than one .exclude file in CESM is now possible.
  2. Skipping one file when more than one file of the same name exists
    is now possible.

It is important to note that .exclude must now contain the relative
path of the file to exclude. Previously only the filename
was present regardless of where it existed in the sub-tree.

Test suite: none yet
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #] No associated issue

User interface changes?: N

Update gh-pages html (Y/N)?: N

Improvements include:
 - Enable using more than one .exclude file. Previously only
   the first file found in the iteration over directories was used.
 - Require relative file path in .exclude. Previously only the filename
   was included even if the file was deeper in the sub-tree.
   This update allows excluding a file even if the same
   filename exists in another subdirectory.

Signed-off-by: Lizzie Lundgren <[email protected]>
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

lizziel added a commit to lizziel/HEMCO_CESM that referenced this pull request Sep 12, 2022
This update should be used with CIME updates submitted in:
ESMCI/cime#4180
ESMCI/cime#4302

Signed-off-by: Lizzie Lundgren <[email protected]>
@jedwards4b jedwards4b requested a review from jgfouca September 12, 2022 19:17
@jgfouca jgfouca merged commit 78de55b into ESMCI:master Sep 12, 2022
lizziel added a commit to geoschem/CAM that referenced this pull request Sep 16, 2022
Previously file only contained filenames. This update should be used with
CIME updates submitted in:
ESMCI/cime#4180
ESMCI/cime#4302

Signed-off-by: Lizzie Lundgren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants