Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error check compset name #1873

Merged
merged 3 commits into from
Sep 8, 2017
Merged

Error check compset name #1873

merged 3 commits into from
Sep 8, 2017

Conversation

jedwards4b
Copy link
Contributor

Improve error checking on compset name, if an alias isn't matched make sure that the compset name (now assumed to be a longname) lists 7 components.

Test suite: scripts_regression_tests.py hand tests of create_newcase
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1871

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:

billsacks
billsacks requested changes Sep 7, 2017
View reviewed changes
Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better than before - thanks.

However, the error message is still cryptic if you make an error in the compset long name (or something that looks like a compset long name). For example (using DTM instead of DATM):

[roo2:~/cime/scripts]$ ./create_newcase --case ~/cime_output_root/test_long_name_0906a --compset 2000_DTM_SLND_SICE_SOCN_SROF_SGLC_DWAV --res f09_g16
Did not find an alias or longname compset match for 2000_DTM_SLND_SICE_SOCN_SROF_SGLC_DWAV
Compset forcing is 1972-2004
ERROR: No variable CONFIG_ATM_FILE found in case

Can it say something like, "Cannot find atmosphere component DTM"?

I'm fine with either:

  1. Incorporating that improvement into this PR

  2. Merging this PR as is, and opening a separate issue for that.

Let me know which you prefer.

@jedwards4b
Copy link
Contributor Author

try again

@billsacks
Copy link
Member

Looks good now, thanks!

@billsacks billsacks merged commit 2b1e151 into ESMCI:master Sep 8, 2017
@jedwards4b jedwards4b deleted the error_check_compset_name branch September 8, 2017 18:15
jgfouca added a commit that referenced this pull request Nov 13, 2017
@jgfouca
Merge branch 'jgfouca/branch-for-to-acme-11-10-2017-pr' into master (PR
1cffd52 
#1894)

Feature list:

* Greatly enhanced capability and configurability for receiving emails from batch system
* New --clean-depends feature for case.build
* Ability to save user-specific defaults for create_test
* Ability to select a different driver via create_newcase or test option
* Many small bug fixes and usability improvements

Fixes #1873

[BFB]

* jgfouca/branch-for-to-acme-11-10-2017-pr: (156 commits)
  partial fix for issue 2048
  USER_REQUESTED_ vars should go in env_batch
  Use_existing needs to set FAIL states back to PEND
  encapsulate routine
  add create_test options to config for user tuned defaults
  Change ACME PIO roots to zero the right way
  If MAIL_TYPE has an underscore, then MAIL_USER should as well
  make config option consistant with cl
  Typo in if-elif construct
  allow create_test to have a different mail_type default
  Add test to make sure successful tests are not re-run by use-existing
  Add support for mail flags to create_test
  convert line to utf-8
  Update ChangeLog
  Big fix.
  Address github feedback
  allow undated history files to be archived
  Change paths to case2 rundir and exeroot
  Allow mail settings to be configured by a users's cime_config
  Improve email handling
  ...
jgfouca added a commit that referenced this pull request Feb 23, 2018
@jgfouca
Merge branch 'jgfouca/branch-for-to-acme-11-10-2017-pr' into master (PR
3f4f836 
#1894)

Feature list:

* Greatly enhanced capability and configurability for receiving emails from batch system
* New --clean-depends feature for case.build
* Ability to save user-specific defaults for create_test
* Ability to select a different driver via create_newcase or test option
* Many small bug fixes and usability improvements

Fixes #1873

[BFB]

* jgfouca/branch-for-to-acme-11-10-2017-pr: (156 commits)
  partial fix for issue 2048
  USER_REQUESTED_ vars should go in env_batch
  Use_existing needs to set FAIL states back to PEND
  encapsulate routine
  add create_test options to config for user tuned defaults
  Change ACME PIO roots to zero the right way
  If MAIL_TYPE has an underscore, then MAIL_USER should as well
  make config option consistant with cl
  Typo in if-elif construct
  allow create_test to have a different mail_type default
  Add test to make sure successful tests are not re-run by use-existing
  Add support for mail flags to create_test
  convert line to utf-8
  Update ChangeLog
  Big fix.
  Address github feedback
  allow undated history files to be archived
  Change paths to case2 rundir and exeroot
  Allow mail settings to be configured by a users's cime_config
  Improve email handling
  ...
jgfouca added a commit that referenced this pull request Mar 13, 2018
@jgfouca
Merge branch 'jgfouca/branch-for-to-acme-11-10-2017-pr' into master (PR
046c7cb 
#1894)

Feature list:

* Greatly enhanced capability and configurability for receiving emails from batch system
* New --clean-depends feature for case.build
* Ability to save user-specific defaults for create_test
* Ability to select a different driver via create_newcase or test option
* Many small bug fixes and usability improvements

Fixes #1873

[BFB]

* jgfouca/branch-for-to-acme-11-10-2017-pr: (156 commits)
  partial fix for issue 2048
  USER_REQUESTED_ vars should go in env_batch
  Use_existing needs to set FAIL states back to PEND
  encapsulate routine
  add create_test options to config for user tuned defaults
  Change ACME PIO roots to zero the right way
  If MAIL_TYPE has an underscore, then MAIL_USER should as well
  make config option consistant with cl
  Typo in if-elif construct
  allow create_test to have a different mail_type default
  Add test to make sure successful tests are not re-run by use-existing
  Add support for mail flags to create_test
  convert line to utf-8
  Update ChangeLog
  Big fix.
  Address github feedback
  allow undated history files to be archived
  Change paths to case2 rundir and exeroot
  Allow mail settings to be configured by a users's cime_config
  Improve email handling
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billsacks billsacks billsacks approved these changes

Assignees

@billsacks billsacks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedwards4b @billsacks