Force user to always go through case.submit #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing problems, don't merge. |
This was already the policy, but was not being enforced correctly.
jgfouca
force-pushed
the
jgfouca/force_resubmit_to_use_submit
branch
from
f207eed to
0a38bb5
Compare
|
Looks good now. |
|
Can I still set RUN_WITH_SUBMIT to FALSE if I want too? |
jedwards4b
approved these changes
Apr 17, 2017
|
@rljacob it was never intended that you could. |
|
Why is there a RUN_WITH_SUBMIT variable? |
|
It's how we make sure that case.submit was used to call case.run, it was never intended to be a mechanism to override that method. |
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 23, 2018
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 13, 2018
BeTR failed when running with the 15.x intel compiler. By updating the compiler configuration and enforce some array shapes during argument passing fixed the bug. Fixes #1326 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already the policy, but was not being enforced correctly.
Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #347
User interface changes?: None
Code review: @jedwards4b